Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38156 - Do not call content on root during re-import #11283

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

quba42
Copy link
Contributor

@quba42 quba42 commented Jan 21, 2025

Detailed description of the reproducer steps, issue, and background in the issue: https://projects.theforeman.org/issues/38156

Affects only RHEL content when the repository being imported already
exists on the importing Katello instance.

This might be the case because it has been added as a "Red Hat
Repository" on both instances from a manifest file. Or else, because
this is a re-import of a newer export state to update a previously
imported state.
@quba42
Copy link
Contributor Author

quba42 commented Jan 21, 2025

I have tested that this fixes the issue and the import that previously failed now completes successfully on our reproducing instance.

There were similar fixes in the PR that broke this. This change should have been part of this PR.

@quba42 quba42 marked this pull request as ready for review January 22, 2025 15:45
@quba42
Copy link
Contributor Author

quba42 commented Jan 22, 2025

I imagine this might be a candidate for back-porting to Katello 4.15 as well!

@sbernhard sbernhard merged commit eca1682 into Katello:master Jan 24, 2025
19 checks passed
@quba42 quba42 deleted the fix_RHEL_reimport branch January 27, 2025 08:34
@quba42
Copy link
Contributor Author

quba42 commented Jan 27, 2025

The ticket for this PR was updated: "Target version changed from Katello 4.16.0 to Katello 4.15.1"

This implies a backport to the KATELLO-4.15 branch.

I don't know what the backport process is. Should I manually create a PR for a cherry-pick?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants